Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
  • Help Room /
avatar image
0
Question by henk88 · Feb 27, 2016 at 03:49 PM · uibuttonunity5

Dynamically add listeners to multiple Buttons

I am using Unity 5.3 and I have the following piece of code that generates a list of Buttons, the idea is for the user to select a level and then play it:

 void BuildLevelSelectList(){
     foreach (Level level in LevelList) {
         GameObject levelTemplateCopy = GameObject.Instantiate (levelTemplate);

         /* removed some code here that is just for layout purposes */
 
         Button button = levelTemplateCopy.GetComponent<Button> ();
         button.onClick.AddListener (() => {
             SelectLevel(level);
         });
     }
 }
 
 void SelectLevel(Level level){
     Debug.Log (level.Name);
 }


The problem is that the Debug.Log (level.Name); always prints the name of the last level in the list for every Button I click on in the list.

I know I'm doing something wrong, can someone please point me in the right direction?

Thanks!

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
2
Best Answer

Answer by hexagonius · Feb 27, 2016 at 04:36 PM

That's because your assigning each button the enumerator of the foreach. I don't know the technical details exactly, but the difference between foreach and for loop is the foreach uses an object that runs over the iterated list or array or whatever. It stays the same object it's just returning the current content. you're buttons get a pointer to that object, which at the end points to the last entry for all buttons. either remove it with a for loop, or create a temporary variable which you assign to the buttons after assigning it the current value. that's called closure.

Comment
Add comment · Show 2 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image henk88 · Feb 29, 2016 at 04:02 AM 0
Share

Great explanation! Thanks

avatar image Magnumstar · Jun 20, 2016 at 11:47 PM 0
Share

Good to know

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

6 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

UI Buttons Trigger displaced after build. Help Please 0 Answers

button ui becomes active by click outside the button in exe file!!(unity 5.1) 1 Answer

Help with button Text and error 1 Answer

Unity Button to switch Bool 1 Answer

Second button works 4 times 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges