Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 11 Next capture
2021 2022 2023
1 capture
11 Jun 22 - 11 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by devstudents · Jul 29, 2015 at 11:40 PM · animationcoroutinelength

Coroutine mystery (for a noob)

For some reason the length of the animation in the first coroutine is carried over to the second. The first animation (Load_Bow) goes for 1.5 seconds (or whatever units 'length' refers to), and the second animation (Draw_Bow) goes for 1 second.

As a result of this, the second animation repeats as it continues until the length of the first animation is complete. I do not know why my code is doing this and I'm assuming I've missed something pretty important about how co-routines work.

     public IEnumerator LoadBow()
     {
         this.gameObject.GetComponent<Animation>().CrossFade("Load_Bow"); 
         yield return new WaitForSeconds(this.gameObject.GetComponent<Animation>()["Load_Bow"].length); 
         aimStates = AimStates.Draw; 
     }
     
     public IEnumerator DrawBow()
     {
         this.gameObject.GetComponent<Animation>().CrossFade("Draw_Bow"); 
         yield return new WaitForSeconds(this.gameObject.GetComponent<Animation>()["Draw_Bow"].length); 
         aimStates = AimStates.Aim; 
     }
         
     public void Aiming()
     {
         moveTarget.SetActive(false); 
         switch(aimStates)
         {
             case AimStates.Load:
                 StartCoroutine(LoadBow()); 
             break;
             
             case AimStates.Draw:
                 StartCoroutine(DrawBow()); 
             break;
Comment
Add comment · Show 5
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image maccabbe · Jul 30, 2015 at 01:26 AM 1
Share

Where are you calling Ai$$anonymous$$g from?

avatar image devstudents · Jul 30, 2015 at 02:04 AM 0
Share

It's part of a larger FS$$anonymous$$ in the same script. The overall FS$$anonymous$$ method is called from another script. Do you think I need to include all that code?

avatar image jn327 · Jul 30, 2015 at 10:44 AM 2
Share

Yeah including the Ai$$anonymous$$g() call would be a good idea, you probably don't want to be calling that every frame if you are.

avatar image meat5000 ♦ · Jul 30, 2015 at 03:34 PM 1
Share

Could be because you are crossfading them.

avatar image devstudents · Jul 30, 2015 at 09:50 PM 0
Share

Thanks guys. Crossfading was a problem. As was having no condition in the load state to say when to activate the coroutine.

1 Reply

· Add your reply
  • Sort: 
avatar image
1
Best Answer

Answer by nullgobz · Jul 30, 2015 at 01:36 PM

The coroutines wont block code calling it. If your calling these coroutines multiple times in for example an Update function. Then you will get the behaviour you have right now. You need to make sure that you only call a coroutine when you acually want it to start. A coroutine only blocks statements after the yield within the function itself.

Example:

 public IEnumerator LoadBow()
 {
    // Play Animation Here!
    aimStates = AimStates.Draw;
    yield return new WaitForSeconds(1.0f);
 
    // Call next animation here!
    DrawBow(); 
 }
 // You could make this a coroutine if i you need something to happen after its done
 public void DrawBow()
 {
    // Play Animation Here!
    aimStates = AimStates.Aim;
 }


Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image devstudents · Jul 30, 2015 at 09:54 PM 0
Share

Thank you. I stopped update from calling it every frame by controlling the LoadBow coroutine with a bool. It works now. meat5000 pointed out that crossfading the animations could also be causing a problem in this instance (and it was).

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

23 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Animation with minimum length? 1 Answer

CORoutine does not completely stop 1 Answer

Wait for animation to finish? Animator.SetBool... 1 Answer

Do Something Relative to Animation Time 1 Answer

Staggered Animations - Do I use Pre-fabs ? 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges