Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by Frankato · May 08, 2017 at 02:19 PM · javascriptcharacter movement

I'm trying to get an object to move using javascript however it won't move, can someone help?

this is the code I used

 var gravity = 9;
 var movSpeed = 9;
 var isMoving = false;
 function Start () {
 
 }
 
 function Update () {
     if(Input.GetButton("Horizontal"))
     {
     isMoving = true;
     }
     while(isMoving)
     {
     if(Input.GetButton("Horizontal"))
     {
     transform.position.x = movSpeed;
     }
     if(Input.GetButtonUp("Horizontal"))
     {
     isMoving = false;
     }
     }
 }


if anyone could help I would be really greatful

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
0

Answer by bobisgod234 · May 09, 2017 at 04:07 AM

Firstly, try to make sure your code is tabbed correctly, as its very hard to see whats in what condition:

  function Update () {
      if(Input.GetButton("Horizontal"))
      {
          isMoving = true;
      }
      while(isMoving)
      {
          if(Input.GetButton("Horizontal"))
          {
              transform.position.x = movSpeed;
          }
          if(Input.GetButtonUp("Horizontal"))
          {
              isMoving = false;
          }
      }
  }


The while loop is unnecessary, update is called repeatedly once a frame already. Since we want to only change the position when Input.GetButton("Horizontal") is true, we can remove most of the rest of the code too.

  function Update () {
      if(Input.GetButton("Horizontal"))
      {
          transform.position.x = movSpeed;
      }
  }

Now here, we are setting the x position of the transform to movSpeed, so each frame the position of the object won't actually change. We want to add movSpeed to the x position, using += instead of =.

  function Update () {
      if(Input.GetButton("Horizontal"))
      {
          transform.position.x += movSpeed;
      }
  }
Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

4 People are following this question.

avatar image avatar image avatar image avatar image

Related Questions

Alternative to using transform.translate and transform.position for moving objects exact values? 1 Answer

Cant Get Character To Move 1 Answer

Translating Javascript code into C# Code 2 Answers

Setting Scroll View Width GUILayout 1 Answer

Can someone help me fix my Javascript for Flickering Light? 6 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges