Try to change Variables from js to c#

Question

Hi I use a c# script to save and load. Now i want to access the c# script variables with a Javascript script. But this won't work like i want to.( I moved the cs script in the Standard Asset folder)

SaveDataCS.cs:

using UnityEngine; // For Debug.Log, etc.

using System.Text; using System.IO; using System.Runtime.Serialization.Formatters.Binary;

using System; using System.Runtime.Serialization; using System.Reflection;

public class SaveDataCS : MonoBehaviour { void Start () { } // === This is the info container class === [Serializable ()] public class SaveData : ISerializable { // === Values === // Edit these during gameplay public bool foundGem1 = false; public float score= 42 ;//= 42; public int levelReached = 3; public int[] HighscoreArraySave = new int[10]; //highscorearrsave public int[] MedalArraySave = new int[10]; //medalarrsave public float[] TimeArraySave = new float[10];//timearr public int LevelSave = 0; // level public string PlayerNameSave = "Playername"; // === /Values === // The default constructor. Included for when we call it during Save() and Load() public SaveData () {}

 // This constructor is called automatically by the parent class, ISerializable // We get to custom-implement the serialization process here public SaveData (SerializationInfo info, StreamingContext ctxt) { // Get the values from info and assign them to the appropriate properties. Make sure to cast each variable. // Do this for each var defined in the Values section above foundGem1 = (bool)info.GetValue("foundGem1", typeof(bool)); score = (float)info.GetValue("score", typeof(float)); levelReached = (int)info.GetValue("levelReached", typeof(int)); HighscoreArraySave = (int[])info.GetValue("HighscoreArraySave", typeof(int[])); MedalArraySave = (int[])info.GetValue("MedalArraySave", typeof(int[])); TimeArraySave = (float[])info.GetValue("TimeArraySave", typeof(float[])); LevelSave = (int)info.GetValue("LevelSave", typeof(int)); PlayerNameSave = (string)info.GetValue("PlayerNameSave", typeof(string)); }

 // Required by the ISerializable class to be properly serialized. This is called automatically public void GetObjectData (SerializationInfo info, StreamingContext ctxt) { // Repeat this for each var defined in the Values section info.AddValue("foundGem1", (foundGem1)); info.AddValue("score", score); info.AddValue("levelReached", levelReached); info.AddValue("HighscoreArraySave",(HighscoreArraySave)); info.AddValue("MedalArraySave",(MedalArraySave)); info.AddValue("TimeArraySave",(TimeArraySave)); info.AddValue("LevelSave",(LevelSave)); info.AddValue("PlayerNameSave",(PlayerNameSave)); } }

// === This is the class that will be accessed from scripts === public class SaveLoad {

 public static string currentFilePath = "SaveData.cjc"; // Edit this for different save files

 // Call this to write data public static void Save () // Overloaded { Save (currentFilePath); } public static void Save (string filePath) { SaveData data = new SaveData ();

 Stream stream = File.Open(filePath, FileMode.Create);
 BinaryFormatter bformatter = new BinaryFormatter();
 bformatter.Binder = new VersionDeserializationBinder(); 
 bformatter.Serialize(stream, data);
 stream.Close();
 Debug.Log("Gesaved2"+ data);

 // Call this to load from a file into "data" public static void Load () { Load(currentFilePath); } // Overloaded public static void Load (string filePath) { SaveData data = new SaveData (); Stream stream = File.Open(filePath, FileMode.Open); BinaryFormatter bformatter = new BinaryFormatter(); bformatter.Binder = new VersionDeserializationBinder(); data = (SaveData)bformatter.Deserialize(stream); stream.Close(); Debug.Log("Geladen2" + data); // Now use "data" to access your Values }

// === This is required to guarantee a fixed serialization assembly name, which Unity likes to randomize on each compile // Do not change this public sealed class VersionDeserializationBinder : SerializationBinder { public override Type BindToType( string assemblyName, string typeName ) { if ( !string.IsNullOrEmpty( assemblyName ) && !string.IsNullOrEmpty( typeName ) ) { Type typeToDeserialize = null;

         assemblyName = Assembly.GetExecutingAssembly().FullName; 

         // The following line of code returns the type. 
         typeToDeserialize = Type.GetType( String.Format( "{0}, {1}", typeName, assemblyName ) ); 

         return typeToDeserialize; 
     } 

     return null; 
 }

} }

and with this JS script it try to access the variables in the SaveData class:

function Update () {
        if (Input.GetKeyUp(KeyCode.S) ){
            SaveDataCS.SaveLoad.Save();  // this works fine
        }
        if (Input.GetKeyUp(KeyCode.L) ){
            SaveDataCS.SaveLoad.Load();  // this works fine too
        }
        if (Input.GetKeyUp(KeyCode.H) ){
            var other : SaveDataCS;
            other = gameObject.GetComponent("SaveDataCS");  // this doesn't work
            print(other.score);
            other.score=10;   // 
        }
        if (Input.GetKeyUp(KeyCode.K) ){
            print(SaveDataCS.score);
            SaveDataCS.score = 10;   // this doesn't work too
        }
    }

I think its the fact that there are to many classes in the C# script. But maybe someone knows a solution. Thanks for answers.

edit1: Both Scripts are on the same GameObject.

Answer 1

Your problem is that your whole script doesn't work.

SaveDataCS is derrived from MonoBehaviour but it's an empty class (it contains no data or methods)
The nested class SaveData looks right but to access it you have to use the full path: SaveDataCS.SaveData
In your SaveLoad class you try to create a instance of your SaveData class, but that should even fail because of the class is nested and you didn't specified the full classname.
Now the biggest thing: You create a local instance of SaveData during saving you didn't set the members to the values you want to save. Loading looks right so far but at the end you have to do something with the data you've just deserialized. The comment looks like a TODO: remark...
Using the SaveDataCS as component is useless since it doesn't contain any data.
You try to access a variable or field called .score, but as i said SaveDataCS is a empty class.
Finally you even try to access .score like it's a static member of the class, but it doesn't contain any variables.

In the end i can't even figure out where the actual data you want to save should come from. You should rethink your whole concept and make sure you know what you want to save.

edit

public class GameManager : MonoBehaviour
{
    public int currentLevel = 1;
    public float health = 100.0f;
    private string playername = "";
}

Just an example. If you want to save currentLevel and health but not the playername you will create a simple class to act as "transfer-class" that just holds your desired data.

public class SaveGameManager : ISerializable { public int currentLevel; public float health;

 public SaveGameManager() { }

 public SaveGameManager (SerializationInfo info, StreamingContext ctxt)
 {
     currentLevel = (int)info.GetValue("currentLevel", typeof(int));
     health = (float)info.GetValue("health", typeof(float));
 }

 public void GetObjectData (SerializationInfo info, StreamingContext ctxt)
 {
     info.AddValue("currentLevel", currentLevel);
     info.AddValue("health", health);
 }

}

To save or load the state of the GameManager you have to provide the actual data to the Saving class.

public class SaveLoad { public static void Save (string filePath, GameManager manager) { SaveGameManager data = new SaveGameManager (); data.currentLevel = manager.currentLevel; data.health = manager.health;

     Stream stream = File.Open(filePath, FileMode.Create);
     BinaryFormatter bformatter = new BinaryFormatter();
     bformatter.Binder = new VersionDeserializationBinder(); 
     bformatter.Serialize(stream, data);
     stream.Close();
 }
 public static void Load (string filePath, GameManager manager)
 {
     Stream stream = File.Open(filePath, FileMode.Open);
     BinaryFormatter bformatter = new BinaryFormatter();
     bformatter.Binder = new VersionDeserializationBinder(); 
     SaveGameManager data = (SaveGameManager)bformatter.Deserialize(stream);
     stream.Close();

     manager.currentLevel = data.currentLevel;
     manager.health = data.health;
 }

}

To save the state of your GameManager just do that (JS):

var manager = Getcomponent.<GameManager>();

SaveLoad.Save("SaveData.cjc",manager);

Loading works the same way...
That's all untested... I've just grabbed some of your code and created this example how it should work. The copying process can be packed into the save-container-class to cleanup the code and provide a bit more general purpose saving class.

Hopefully that helps a bit ;)

Sorry for the long post, have a nice day
(greetings from germany ;))

Answer 2

Answer by CHPedersen · Apr 28, 2011 at 10:41 AM

Component.gameObject references the GameObject that Component is attached to. So when you write,

other = gameObject.GetComponent("SaveDataCS");

You're asking for a component with the name "SaveDataCS" that is attached to the same GameObject as the JS-script with that line in it. If that GameObject doesn't have a component with that name, other will remain null.

Add comment · Show 1 · Share

Pflegeleichtt · Apr 28, 2011 at 11:14 AM 0

Share

yes i know, i added both scripts to one gameobject as component

Try to change Variables from js to c#

2 Replies

Your answer

Follow this Question

Related Questions