Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by baerbel · Oct 28, 2015 at 12:57 PM · editorundo

Undo in Editor only executed when I switch focus to Hierarchy

I am currently trying to write a custom editor that uses drag and drop. I have managed to get it running by setting the controlID. Unfortunately, when I do this Undo only works when I switch focus away from the Scene. The weirdest thing is that while it does nothing the menu item for Undo still highlights. Am I somehow using the controlID in a wrong way, or do I need to forward the keyboard controls somehow?

I have built a minimal example, that has the problem. I add a behavior to a simple Game Object like a cube:

 public class CubeBehavior : MonoBehaviour {
 
     public int value = 0;
 
 }

Next I create a custom editor that increases the value with every mouse click. I also register this change for undo. It works, but only once I set focus outside of the Scene.

 using UnityEngine;
 using System.Collections;
 using UnityEditor;
 
 [CustomEditor (typeof(CubeBehavior))]
 public class CubeEditor : Editor {
 
     CubeBehavior cubeBehavior;
 
     void OnEnable() {
         cubeBehavior = (CubeBehavior)target;
         SceneView.onSceneGUIDelegate -= OnScene;
         SceneView.onSceneGUIDelegate += OnScene;
     }
 
     public override void OnInspectorGUI() {
         EditorGUILayout.BeginHorizontal();
         cubeBehavior.value = EditorGUILayout.IntField (cubeBehavior.value);
         EditorGUILayout.EndHorizontal();
     }
 
     void OnScene(SceneView sceneview) {
         Event e = Event.current;
         
         int controlID = GUIUtility.GetControlID (FocusType.Passive);
         EventType eventType = e.GetTypeForControl (controlID);
         
         Ray r = Camera.current.ScreenPointToRay(new Vector3(e.mousePosition.x, -e.mousePosition.y + Camera.current.pixelHeight));
         Vector3 mousePos = r.origin;
         
         if (eventType == EventType.MouseUp) {
             Undo.RegisterUndo (target, "Edit " + target);
             Undo.IncrementCurrentGroup ();
             ((CubeBehavior) target).value ++;
             GUIUtility.hotControl = controlID;
             e.Use ();
         }
     }
 
 }

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

0 Replies

· Add your reply
  • Sort: 

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

3 People are following this question.

avatar image avatar image avatar image

Related Questions

unity not undoing transform changes? 1 Answer

How to record hideFlags for Undo/Redo 0 Answers

Get Undo.DestroyObjectImmediate to work nicely when removing a List/array element that's pointing to a MonoBehaviour? 4 Answers

Editor undo generic collection C# 0 Answers

Undo.RecordObject doesn't work 2 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges