Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by Love N · Nov 24, 2010 at 04:55 PM · memory-leakcar-tutorial

Memory leak in Car Tutorial ?

Hi Folks,

In the SetupWheel function of the Car.js script there is what seems to me like a leak.
The GameObject variable go is reused without having been assigned anywhere.
In a third gen language like C/C++, this would certainly cause a memory leak.

A WheelCollider wc is added to the go object, and assigned to the Wheel instance,
but go itself is not assigned to anything. When (if?) wheel is deleted, it's collider wc
will get orphaned unless Wheel deletes it, so You'll leak a WheelCollider, and it's owner
(the previous go) will get orphaned even if wc is deleted, and You'll leak a GameObject.

However, I'm a C++ programmer and quite new to scripting systems,
so I might be missing some fine point about UnityScript.

Could anyone please throw some light on this?

Is it a leak (as it seems to me), or does it rely on some built in
safety mechanism of the scripting language to save the day?
I'm learning UnityScript, so some enlightenment would be very appreciated.

Thanks and Best Regards
// Love N

[ Here's the function, with my remarks on the spot ]

function SetupWheel( wheelTransform : Transform, isFrontWheel : boolean ) { var go : GameObject = new GameObject( wheelTransform.name + " Collider" ); go.transform.position = wheelTransform.position; go.transform.parent = transform; go.transform.rotation = wheelTransform.rotation;

 var wc : WheelCollider = go.AddComponent( typeof( WheelCollider )) as WheelCollider;
 wc.suspensionDistance = suspensionRange;

 var js : JointSpring = wc.suspensionSpring;
 if (isFrontWheel)
     js.spring = suspensionSpringFront;
 else
     js.spring = suspensionSpringRear;

 js.damper = suspensionDamper;
 wc.suspensionSpring = js;

 wheel = new Wheel(); 
 wheel.collider = wc;
 wc.sidewaysFriction = wfc;
 wheel.wheelGraphic = wheelTransform;
 wheel.tireGraphic = wheelTransform.GetComponentsInChildren( Transform )[1];

 wheelRadius = wheel.tireGraphic.renderer.bounds.size.y / 2; 
 wheel.collider.radius = wheelRadius;

 if (isFrontWheel)
 {
     wheel.steerWheel = true;

     // 'go' is reused without previous object having been assigned to anything.
     // This looks like a classic leak to a driven C++ programmer like me.
     // What's the deal here ?

     go = new GameObject( wheelTransform.name + " Steer Column" );
     go.transform.position = wheelTransform.position;
     go.transform.rotation = wheelTransform.rotation;
     go.transform.parent = transform;
     wheelTransform.parent = go.transform;
 }
 else
     wheel.driveWheel = true;

 return wheel;

}

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

2 Replies

· Add your reply
  • Sort: 
avatar image
1

Answer by Mike 3 · Nov 24, 2010 at 05:07 PM

It doesn't make any difference, no - the engine is the one keeping the references to the new objects (including the native c++ objects created behind the scenes), so when it needs deleting, it'll be done at that end

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image
0

Answer by Love N · Nov 27, 2010 at 12:34 PM

Ah, I see. That makes life incredibly easy :)

Thanks Mike. WBR // Love

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

No one has followed this question yet.

Related Questions

Rear wheels move to the center of the car object in car tutorial 1 Answer

What is the best way to modify the Car Tutorial for more cars? 2 Answers

Assets never unloading after loading next scene 1 Answer

200MB file save causing unity memory to increase by over a gigabyte 1 Answer

How do I avoid memory leaks when setting UI.Text.text? 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges