Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by Kanel · Nov 25, 2016 at 06:29 AM · scripting problemscript error

Spawn Script Instantiate Method?

Hey,

I am trying to build a tetris clone on my own. I know there are alot of tutorials but I am trying to get things done myself.

I got my prefabs (Blocks) done and also made this prefabs move to the bottom. After that I tried to build the spawn Script, which is attached to my GameController. I used a random.value to determine which block to spawn next. Obviously the instantiate part is repeated quite often, so I decided to make spawn() function. The Script didn't work that way tho. It works without the function... repeating the instantiate code part in every if statement.

Be aware it looks messy. I tried out alot of stuff and kept changing the code for around 2 hours now.

 using UnityEngine;
 using System.Collections;
 
 public class GameController : MonoBehaviour {
     public GameObject tBlock;
     public GameObject zBlock;
     public GameObject secondZBlock;
     public GameObject lBlock;
     public GameObject secondLBlock;
     public GameObject iBlock;
     public GameObject sBlock;
 
     public Vector3 spawnValues;
 
     public float startWait;
     public float spawnWait;
 
     
 
     
 
     // Use this for initialization
     void Start () {
         StartCoroutine(SpawnBlocks());
 
     }
     
     // Update is called once per frame
     void Update () {
         
         
 
 
     }
 
     IEnumerator SpawnBlocks()
 
     // Spawns Waves of asteroids
     {
         yield return new WaitForSeconds(startWait);
         //while (true)
        // {
             for (int i = 0; i < 10; i++)
             {
 
 
                 float z = Random.value;
                 if (z <= 0.2)
                 {
                     spawn(tBlock);
                 }
                 else if (z <= 0.4 && z > 0.2)
                 {
                     spawn(sBlock);
                 }
                 else if (z <= 0.6 && z > 0.4)
                 {
                     spawn(iBlock);
                 }
                 else if (z <= 0.8 && z > 0.6)
                 {
                     if (z <= 0.7)
                     {
                         spawn(lBlock);
                     }
                     else
                     {
                         spawn(secondLBlock);
                     }
 
                 }
                 else
                 {
                     if (z <= 0.9)
                     {
                         spawn(zBlock);
                     }
                     else
                     {
                         spawn(secondZBlock);
                     }
                 }
             }
        
         }
 
     //}
     IEnumerator spawn(GameObject x)
     {
         Vector3 spawnPosition = new Vector3(Random.Range(-spawnValues.x, spawnValues.x), spawnValues.y, spawnValues.z);
         Quaternion spawnRotation = Quaternion.identity;
         Instantiate(x, spawnPosition, spawnRotation);
         yield return new WaitForSeconds(spawnWait);
     }
 }
 
Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
0

Answer by slavo · Nov 25, 2016 at 10:23 AM

Hi,

if you want to call another Courotine and have your original Coroutine to wait until it finished you have to return Coroutine call. So your code will looks like this.

         yield return new WaitForSeconds(startWait);
         while (true)
         {
             for (int i = 0; i < 10; i++)
             {
 
 
                 float z = Random.value;
                 if (z <= 0.2)
                 {
                     yield return spawn(tBlock);
                 }
                 else if (z <= 0.4 && z > 0.2)
                 {
                     yield return spawn(sBlock);
                 }
                 else if (z <= 0.6 && z > 0.4)
                 {
                     yield return spawn(iBlock);
                 }
                 else if (z <= 0.8 && z > 0.6)
                 {
                     if (z <= 0.7)
                     {
                         yield return spawn(lBlock);
                     }
                     else
                     {
                         yield return spawn(secondLBlock);
                     }
 
                 }
                 else
                 {
                     if (z <= 0.9)
                     {
                         yield return spawn(zBlock);
                     }
                     else
                     {
                         yield return spawn(secondZBlock);
                     }
                 }
             }
         }


In older versions of unity you have to also start unity. So your code needs to be

 yield return StartCoroutine(spawn(secondZBlock));
Comment
Add comment · Show 2 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Kanel · Nov 26, 2016 at 03:53 PM 0
Share

Thanks alot, slavo!

avatar image slavo Kanel · Nov 28, 2016 at 11:15 AM 0
Share

No problem. If my post solve your problem, you can mark it as "answer" for future references.

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

4 People are following this question.

avatar image avatar image avatar image avatar image

Related Questions

Draw call minimizer 1 Answer

Cannot convert type 'UnityEngine.GameObject' to 'GameObject' 1 Answer

Help with script 1 Answer

[C#] Quaternion Rotations with Input.GetAxis problems. 1 Answer

Respawn Point dont work, is because is a prefab? 2 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges