Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
  • Help Room /
avatar image
0
Question by Commander-Rabbit · Oct 22, 2016 at 06:24 PM · falsetrue

My method is called more than once.

So basically in my game to drop armor that's on you press Q and Shift and when you press it my dropping bool turns true so my armor drop method will only be called once but its not working it still gets called 2 or more times heres the code.

 public Helmet HeadGear;
  public Leggings PantsGear;
  public ChestPlate ChestGear;
  public Boots ShoeGear;
  public bool ArmorDropping;
 
  if (Input.GetKey(KeyCode.Q)&& Input.GetKey(KeyCode.LeftShift))
             {
             ArmorDrop();
             ArmorDropping  =  true;
         }
 void ArmorDrop()
     {
         if (ArmorDropping == true)
         {
             if (HeadGear != null)
             {
                 HeadGear = null;
                 ArmorDropping = false;
             }
             else
             {
                 if (ChestGear != null)
                 {
                     ChestGear = null;
                     ArmorDropping = false;
                 }
                 else
                 {
                     if (PantsGear != null)
                     {
                         PantsGear = null;
                         ArmorDropping = false;
                     }
                     else
                     {
                         Debug.Log("No Armor on");
                         ArmorDropping = false;
                     }
                 }
             }
         }
     }



Comment
Add comment · Show 1
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Commander-Rabbit · Oct 22, 2016 at 06:26 PM 0
Share

Sorry code came out wrong public Helmet HeadGear; public Leggings PantsGear; public ChestPlate ChestGear; public Boots ShoeGear; public bool ArmorDropping;

if (Input.Get$$anonymous$$ey($$anonymous$$eyCode.Q)&& Input.Get$$anonymous$$ey($$anonymous$$eyCode.LeftShift)) { // Get help for this ArmorDrop(); ArmorDropping = true;

     }

void ArmorDrop() { if (ArmorDropping == true) { if (HeadGear != null) { HeadGear = null; ArmorDropping = false; } else { if (ChestGear != null) { ChestGear = null; ArmorDropping = false; } else { if (PantsGear != null) { PantsGear = null; ArmorDropping = false; } else { Debug.Log("No Armor on"); ArmorDropping = false; } } } } }

1 Reply

· Add your reply
  • Sort: 
avatar image
0

Answer by hexagonius · Oct 22, 2016 at 07:36 PM

GetKey will return true for every frame that's passed since you pressed the key. Use GetKeyDown instead, which ensures, that only the press is used.
Furthermore, the boolean ArmorDropping is useless, you can remove it, it's set to true "after" calling the method checking it, so the first call always returned, but since you used GetKey it worked the second time :)

Comment
Add comment · Show 2 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Commander-Rabbit · Oct 26, 2016 at 12:13 AM 0
Share

But when i use keydown its hard to press Q and Shift in the same frame

avatar image ScaniX Commander-Rabbit · Oct 26, 2016 at 12:30 PM 0
Share

SHIFT is a so called modifier, like CTRL and ALT. Use Get$$anonymous$$ey() for modifiers, which checks whether the key is pressed "at the moment". Use Get$$anonymous$$eyDown() for other keys to check if the user started pressing it "right now".

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

77 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Can't reactivate object after I set it to inactivate 1 Answer

If statement not working 1 Answer

How to save Component 1 Answer

Assets/health.cs(11,23): error CS1519: Unexpected symbol `=' in class, struct, or interface member declaration 1 Answer

Animation Problem 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges