Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
  • Help Room /
avatar image
0
Question by Willox · Dec 30, 2015 at 03:07 PM · infinitewhile loop

Why is this making an infinite loop?

Hello, I'm pretty sure this is making an infinte loop, but I can't find out why. Please, any help? :D

 void DartSpawning ()
     {
         movingDart = Instantiate (dart, new Vector3 (xPosition, yPosition, -10f), Quaternion.Euler (90, 0, 0)) as GameObject;
 
         while (movingDart.transform.position.z != 20.5f) 
         {
             movingDart.transform.position = new Vector3 (movingDart.transform.position.x, movingDart.transform.position.y, movingDart.transform.position.z + dartSpeed);
         }
 
     }
Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

2 Replies

· Add your reply
  • Sort: 
avatar image
1
Best Answer

Answer by Dave-Carlile · Dec 30, 2015 at 05:03 PM

In general, comparing floating point values for equality/inequality is not a good idea. Due to rounding and precision, how movement is scaled by Time.deltaTime, and many other reasons, chances are the value isn't going to exactly equal a constant.

There are various ways of dealing with this. You can use the Mathf.Approximately function to see if a value is really close to your constant. This works well when you're dealing specifically with rounding issues.

In your case you're constantly increasing your z value, so rather than checking z = 20.5f you can check for z >= 20.5f since z will eventually be greater than 20.5 if not exactly 20.5. In this case you often want to force the final value back to the maximum value you want it to be.

Finally, as @jmonasterio pointed out, this sort of code should either be in Update where you execute one update per frame. Or you could put it in a Coroutine and yield during each iteration.

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image
1

Answer by jmonasterio · Dec 30, 2015 at 04:46 PM

To start with, your lines 5-8 should probably be in an Update() function. You'll want to get rid of the while loop, too. And just update the position on each frame, when Update() is called.

As for why it's an infinite loop? Maybe dartSpeed is 0?

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

37 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Potential infinite while loop? 1 Answer

Raycast.distance not working in a while loop 0 Answers

How can I make an endless zoom with endless objects appearing and an endless environment? 1 Answer

So this code is crashing Unity only sometimes... 1 Answer

How do i fix this infinite while loop? 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges