Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by Noxury · Apr 25, 2016 at 04:50 PM · bug-perhapsintfor-looponclickparameter

[Bug?] int parameter on dynamically added onClick-Event is wrong

Hey all,

I am making a shop where one can buy weapons. The UI-Buttons to buy the weapons are created dynamically.

If pressed, the button should call the function "BuyWeapon(i)" that gives the player the right weapon from a list, based on the parameter 'i' of the for-loop.

 void Start(){
     for(int i = 0; i < weapons.Count; i++){
         Debug.Log(i);//returns i
         //Instantiate button-prefab
         GameObject go = Instantiate(Resources.Load("Button"),Vector3.zero,container.rotation) as GameObject;
 
         //Add function BuyWeapon() to onClick of current button
         UnityEngine.Events.UnityAction buy = () => { this.BuyWeapon(i); };//passes i as parameter
         go.GetComponent<Button>().onClick.AddListener(buy);
     }
 }

 public void BuyWeapon(int i){
     Debug.Log(i);//returns always weapons.Count, not buttons' index-parameter
     player.itemsList.Add(weapons[i]);
 }

However, if I click any button, I will get an OutOfRange-Error on the function BuyWeapon() because the parameter 'i' on each onClick-event is equals "weapons.Count". But on Start() 'i' will return its value and so it should pass it to the AddFunction-Part.

This is paradox.

Thanks in advance.

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
5
Best Answer

Answer by Dave-Carlile · Apr 25, 2016 at 06:46 PM

Yes, it's a bug in your code. Your anonymous function is capturing the variable i, not the value of i. You must make a local copy of the variable i inside of the anonymous function. Otherwise you're just getting whatever the last value of i is.

e.g...

 int localIndex = i; 
 buy = () => { this.BuyWeapon(localIndex); };


You can refer to this Stack Overflow question for more information.

And this 2 part article by Erik Lippert.

Comment
Add comment · Show 2 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Noxury · Apr 25, 2016 at 08:45 PM 1
Share

Thank you so much! The localIndex-Variable had to be above this snippet to work, but now it works like a charm!

avatar image Dave-Carlile Noxury · Apr 25, 2016 at 08:50 PM 0
Share

Yes, good catch! I edited the example accordingly.

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

42 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

List of Buttons: Adding a listener passes Last element? 2 Answers

Edit each Parameter Class on Function 1 Answer

Whole Numbers Divide Incorrectly....BUG? 0 Answers

Onclick.Addlistener issues in for statement. (also network related). 1 Answer

Value of Enum changes randomly 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges