Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
  • Help Room /
avatar image
0
Question by Hallinskioi · Feb 21, 2016 at 09:50 AM · player2d-platformer

My character is not taking damage.

Hey guys, this is one of my first scripts in Unity, so I am pretty weak, but any help is much appreciated. Basically I want my character to take 20 points of damage every time he moves into a fire (there is a 2.5 second delay though if he's already in the fire). My issue is that when he goes into the fire, nothing happens. His current health remains at 100. I am using Unity 5.3.1f.

This is my code so far:

 public class Fire_Damage : MonoBehaviour
 {
     public int startingHealth = 100;
     public int currentHealth;
     public Slider HealthBar;
     public float timeperBurn = 2.5f;
     public int FlameDamage = 20;
     private Player_Control player_Control;
     private bool isDead;
 
     GameObject player;
     FireHealth FCHealth;
     float timer;
     bool onFire;
     GameObject fire;
 
     void Awake()
     {
         currentHealth = startingHealth;
         player_Control = GetComponent<Player_Control>();
         player = GameObject.FindGameObjectWithTag("Player");
         FCHealth = GetComponent<FireHealth>();
         fire = GameObject.FindGameObjectWithTag("Fire");
     }
 
 
     void OnTriggerEnter (Collider other)
 
     { 
         if (other.gameObject == fire)
         {
             onFire = true;
         }
     }
 
     void OnTriggerExit (Collider other)
     {
         if (other.gameObject == fire)
         {
             onFire = false;
         }
     }
     void Death()
     {
         isDead = true;
         player_Control.enabled = false;
     }
     void Update()
         {
             if (onFire)
             {
             if (timer > Time.time)
             {
                 currentHealth -= FlameDamage;
                 timer = Time.time + timeperBurn;
                 HealthBar.value = currentHealth;
                 if (currentHealth <= 0 && !isDead)
                 {
                     Death();
                 }
             }
             }
         }
 }

In the console I only get the error that FireHealth is never used (that's my next task). So what am I missing here? Thanks.

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
0

Answer by jgodfrey · Feb 21, 2016 at 03:37 PM

The only place where "timer" is assigned a value is inside an if block where you verify that "timer > Time.time". However, since "timer" is never given an initial value, I don't see how you could ever get inside that if block.

Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Hallinskioi · Feb 21, 2016 at 04:37 PM 0
Share

(Not able to work on it right now) So I should assign timer a value and then it'll work?

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

4 People are following this question.

avatar image avatar image avatar image avatar image

Related Questions

Health is not lowering right? 0 Answers

Player bounce when not supposed to 1 Answer

Player automatically jumping off enemy after kiling it. 0 Answers

Player get's stuck on Tilemap Collider 2D 0 Answers

Move enemy towards player if enemy is in Camera bounds? 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges