Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by binary_biscuit · Oct 20, 2015 at 02:27 PM · shadersprites

Custom Shader makes sprite darker (unintended side effect)

Let me just start off by saying that my experience with this subject is very little indeed. I wrote with the help of online tutorials a custom shader to make certain colored pixels transparent. But an unintended side effect was that my sprites turn much darker:

http://imgur.com/9xFfhDa

Is this a gamma issue or perhaps something to do with shadows I wonder?

*Edit - code now included

 Shader "Custom/transparent-color" {
 
      Properties {
          _Color ("Color", Color) = (1,1,1,1)
          _TransparentColor ("Transparent Color", Color) = (1,1,1,1)
          _Threshold ("Threshhold", Float) = 0.1
          _MainTex ("Albedo (RGB)", 2D) = "white" {}
      }
      SubShader {
          Tags { "Queue"="Transparent" "RenderType"="Transparent" }
          LOD 200
          
          CGPROGRAM
          #pragma surface surf Lambert alpha
  
          sampler2D _MainTex;
  
          struct Input {
              float2 uv_MainTex;
          };
  
          fixed4 _Color;
          fixed4 _TransparentColor;
          half _Threshold;
  
          void surf (Input IN, inout SurfaceOutput o) {
             
              half4 c = tex2D (_MainTex, IN.uv_MainTex);
              half4 output_col = c * _Color;
              half3 transparent_diff = c.xyz - _TransparentColor.xyz;
              half transparent_diff_squared = dot(transparent_diff,transparent_diff);
              
              if(transparent_diff_squared < _Threshold)
                  discard;
              
              o.Albedo = output_col.rgb;
              o.Alpha = output_col.a;
          }
          ENDCG
      } 
      FallBack "Diffuse"
  }

 
Comment
Add comment · Show 3
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image cjdev · Oct 21, 2015 at 05:31 AM 1
Share

Can you include the shader code?

avatar image binary_biscuit cjdev · Oct 21, 2015 at 01:21 PM 0
Share

Ah sorry, I really should have included it originally. I've edited it in.

avatar image Bunny83 · Oct 21, 2015 at 01:44 PM 0
Share

You don't seem to use the alpha value in any way. Why do you have the shader in the transparent render queue? You haven't enabled any kind of alpha blending so that seems to be a bit strange. When using "discard" the big advantage is that you can keep the shader an opaque shader. So the objects don't need to be depth sorted for blending.

In your screenshot it's hard to tell which parts acually belongs together. Finally how many lights and what kind of lights do you use in your scene?

1 Reply

· Add your reply
  • Sort: 
avatar image
1
Best Answer

Answer by cjdev · Oct 21, 2015 at 06:34 PM

Because you're multiplying your color from your tex2D by your Color variable, if you assign any Color other than white you're going to get a darker color than your tex2D input as a result of the multiplication operation since the Color value is a number from 0-1. Try using a different blending formula for the Color and tex2D inputs to get the output you're looking for.

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

33 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

2D Sprite Shader Acting like Light 0 Answers

Skew a sprite at runtime while preserving the pixel shape? 1 Answer

Blend colors in overlapping areas. 1 Answer

Are shaders more efficient than manual pixel replacement? 0 Answers

Grass shader sprite 2D 3 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges