Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by JulesPomme · Oct 14, 2015 at 03:31 PM · custom-inspector

Custom Inspector, variable updating problem

Hi all, I have a problem with a CustomEditor that is driving me crazy... I have a class named WaveformGenerator that generates sound given a specific waveform, with a type (sinus, triangle, custom, etc.) a frequency and a gain. I have a CustomEditor for this class, WaveformGeneratorEditor, that allows me to select and display the waveform. Here is a picture :

alt text

I want to change the display of the curve when I change the type of my waveform. Also, if I change manually the curve, I want my waveform type to change automatically to "custom".

My CustomEditor is supposed to do that, here is the code :

 public override void OnInspectorGUI() {
         WaveformGenerator generator = (WaveformGenerator)target;
 
         EditorGUILayout.PropertyField(serializedObject.FindProperty("active"));
         EditorGUILayout.PropertyField(serializedObject.FindProperty("type"));
         EditorGUILayout.PropertyField(serializedObject.FindProperty("waveform"));
 
         //If my waveform type has changed, update the curve
         if ((int)generator.type != generator.PreviousWaveformTypeIndex) {
             Waveform waveform = Waveform.GetFromType(generator.type);
             if (waveform != null) {
                 waveform.Init(generator.waveform.gain, generator.waveform.frequency);
                 generator.waveform = waveform;
                 int resolution = 64;
                 float[] signal = generator.waveform.GetWaveformSample(resolution);
                 Keyframe[] keys = new Keyframe[signal.Length];
                 for (int i = 0; i < signal.Length; i++) {
                     keys[i] = new Keyframe(2 * Mathf.PI * i / (float)resolution, signal[i]);
                 }
                 generator.PredefinedCurve = new AnimationCurve(keys);
                 generator.CurrentCurve = new AnimationCurve(keys);
                 generator.PreviousWaveformTypeIndex = (int)generator.type;
             }
         }
 
         generator.CurrentCurve = EditorGUILayout.CurveField(generator.CurrentCurve, GUILayout.Height(50));
 
         //If curve has been changed manually, change the waveform type to "custom"
         if (!generator.CurrentCurve.keys.SequenceEqual(generator.PredefinedCurve.keys)) {
             generator.type = WaveformType.Custom;
             Waveform waveform = new CustomWaveform(GetValuesFromKeys(generator.PredefinedCurve.keys));
             waveform.Init(generator.waveform.gain, generator.waveform.frequency);
             generator.waveform = waveform;
             generator.PredefinedCurve.keys = generator.CurrentCurve.keys;
             generator.PreviousWaveformTypeIndex = (int)generator.type;
         }
 
         serializedObject.ApplyModifiedProperties();
         if (GUI.changed)
             EditorUtility.SetDirty(target);
     }

In this code, you can see that I modify some variables of my WaveformGenerator. Those variables are declared as follows :

     [SerializeField]
     int previousWaveformTypeIndex = -1;
     public int PreviousWaveformTypeIndex { get { return previousWaveformTypeIndex; } set { previousWaveformTypeIndex = value; } }
     [SerializeField]
     AnimationCurve currentCurve = new AnimationCurve();
     public AnimationCurve CurrentCurve { get { return currentCurve; } set { currentCurve = value; } }
     [SerializeField]
     AnimationCurve predefinedCurve = null;
     public AnimationCurve PredefinedCurve { get { return predefinedCurve; } set { predefinedCurve = value; } }

I have two problems with this :

1) when I modify the type of my waveform in the inspector, sometimes the curve is not updated. For instance if I go from Sinus to Sawtooth everything works well, but if I go back to Sinus, my curve stays on Sawtooth. I don't understand why !!

2) when I modify manually the curve, the type variable is changed to custom, but the change is not display in the inspector. For instance if I modify manually the Sinus curve, the type is changed to Custom in my class (I checked with a print), but the inspector tells me I'm still on a Sinus.

Any idea ? If you need any additional information please ask me.

Thanks !

waveformgenerator.png (8.1 kB)
Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

0 Replies

· Add your reply
  • Sort: 

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

3 People are following this question.

avatar image avatar image avatar image

Related Questions

calculate things... and display in inspector 3 Answers

How to correctly register Undos in Custom Inspector (within OnInspectorGUI)? 4 Answers

Variable property drawer height effects all in List 4 Answers

Creating enum using a string array 3 Answers

Serializing object in scene? 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges