Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
  • Help Room /
avatar image
0
Question by kingfrodo231 · Sep 21, 2015 at 05:44 PM · unity 5javascriptcrashwhile-loop

My while loop seems to crash unity

HI,

My code seems to crash unity I suspect its the while loop not being able to end any suggestions. #pragma strict

 var changeCircleColor : int = 1;
 var circleColor : String;
 var gameState : String;
         
 function Start ()
 {
     Debug.Log("The game has started");
     gameState = "play";
 }
   
 function Update ()
 {
     while (gameState == "play") 
     {   
         ChangeCircleColor();
         if(Input.GetKeyDown(KeyCode.Space))
         {
             gameState == "stop";
         }
     }
 }
 
 function ChangeCircleColor ()
 {
     if(changeCircleColor == 1)
     {
         gameObject.GetComponent.<Renderer>().material.color = Color.green;
         circleColor = "green";
         changeCircleColor = Random.Range(1,2);
     }
     if(changeCircleColor == 2)
     {
         gameObject.GetComponent.<Renderer>().material.color = Color.red;
         circleColor = "red";
         changeCircleColor = Random.Range(1,2);
     }
 }

Tnx Adam

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
0

Answer by matthewseaward · Sep 21, 2015 at 06:03 PM

The Update method is called every frame - your codes getting stuck in the While loop because Unity hasn't been given the chance to check for an input from a user so it won't detect that the key has been pressed. You don't need a 'While' loop it's not needed. Remove it and it should work fine :)

 function Update ()
  {
          ChangeCircleColor();
          if(Input.GetKeyDown(KeyCode.Space))
          {
              gameState == "stop";
          }  
  }


Comment
Add comment · Show 2 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image mirkobon · May 23, 2016 at 08:09 PM 0
Share

And if you only want it to happen during the timeframe that the game state = play you you could use an boolean

avatar image Wolfrik_Creations · May 29, 2016 at 10:28 PM 0
Share

Yes, don't use a while loop in anything other than a coroutine.

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

36 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Unity keeps crashing when 'While' is used... 1 Answer

Hello friends, how should i learn to code? 2 Answers

UnassignedReferenceException: The variable Target of AI has not been assigned [Error] 1 Answer

Helppp mee script unity 5 1 Answer

help with switching camera 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges