Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 11 Next capture
2021 2022 2023
1 capture
11 Jun 22 - 11 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by rataman098 · Jul 28, 2015 at 08:50 PM · javascripterror

Command "GetButton" not working well

I was making a Firethrower script on JavaScript, and I read that the command "GetButton" sets "true" when the key is holded, and sets "false" when not. But in my case, when I press the key, becomes "true", and doesn't come false never. There's the code:

alt text

PS: Sorry for my English.

2015-07-28-174852.png (5.9 kB)
Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

2 Replies

· Add your reply
  • Sort: 
avatar image
1
Best Answer

Answer by Dave-Carlile · Jul 28, 2015 at 08:52 PM

You need to handle the false condition to set the flameThrower back to inactive...

 if (Input.GetButton("Fire1"))
 {
   flameThrower.SetActive(true);
 }
 else
 {
   flameThrower.SetActive(false);
 }

The code you have now is activating the flamethrower when the button is first pressed, but you don't have anything to deactivate it. When GetButton returns false in my sample code, flameThrower will be set to inactive.

You can shorten this up a bit by just passing the boolean result of GetButton directly to the SetActive method.

 flameThrower.SetActive(GetButton("Fire1"));

But whether or not you want to do that depends on if you have other things to do with the button is held down or not.

Comment
Add comment · Show 2 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image rataman098 · Jul 29, 2015 at 03:13 PM 0
Share

Thanks! It worked very well! (Sorry if I am too much noob, I'm using Unity for three days).

avatar image Dave-Carlile · Jul 29, 2015 at 03:36 PM 0
Share

Everyone has to be a noob at some point :). No need for apologies.

avatar image
1

Answer by Djohnnys · Jul 28, 2015 at 09:53 PM

If I understand correctly you want the flamethrower to only be active when the button is pressed.

In this case you have forgotten to turn it of (set it to inactive) with an else statement.

 function Update()
 {
    if (Input.GetButton("Fire1")
    {
       flameThrower.SetActive(true);
    }
    else //if the button is not pressed
    {
       flameThrower.SetActive(false);
    }
 }
Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image rataman098 · Jul 29, 2015 at 03:15 PM 0
Share

I haven't tested your answer, but it seems that it would work. Thank you anywhere!

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

4 People are following this question.

avatar image avatar image avatar image avatar image

Related Questions

Ball jumping mechanic, scrip errors. 1 Answer

[UNSOLVED] Object reference not set to an instance of an object 0 Answers

Unity freezes when I add a special script 1 Answer

It is not possible to invoke an expression of type 'UnityEngine.GameObject'? 1 Answer

Sound system not working correctly 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges